ENT-9757: Main navigation width adjustment #3131
Conversation
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/426/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-426/output/_site/ |
Ticket: ENT-9757 Changelog: None Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>
mineralsfree
force-pushed
the
ENT-9757
branch
from
48d38cd to
b7e261e
Compare
|
@cf-bottom jenkins, 🥺 |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/427/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-427/output/_site/ |
|
@cf-bottom jenkins, 🙏 🥺 |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/428/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-428/output/_site/ |
mineralsfree
changed the title
mineralsfree
force-pushed
the
ENT-9757
branch
from
2c1dfe2 to
493142f
Compare
|
@cf-bottom jenkins, please |
1 similar comment
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/429/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-429/output/_site/ |
mineralsfree
force-pushed
the
ENT-9757
branch
from
493142f to
af513e4
Compare
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/432/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-432/output/_site/ |
|
Got an approve from Chiacheng about the implementation |
| @@ -32,4 +32,4 @@ | |||
| @desktop-wide-down: ~'(max-width: 1439px)'; | |||
| @desktop-down: ~'(max-width: 1279px)'; | |||
| @tablet-down: ~'(max-width: 1023px)'; | |||
| @phone-down: ~'(max-width: 589px)'; | |||
| @phone-down: ~'(max-width: 589px)'; | |||
There was a problem hiding this comment.
please add new line to the end of the file
| @@ -41,7 +41,8 @@ | |||
| flex-direction: column; | |||
| background: #FFFFFF; | |||
| z-index: 10; | |||
| width: 24.3rem; | |||
| width: clamp(243px, 50%, 433px); | |||
| min-width: 24.3rem; | |||
There was a problem hiding this comment.
no need to use min-width as clam's first arg is responsible for it
| @@ -41,7 +41,8 @@ | |||
| flex-direction: column; | |||
| background: #FFFFFF; | |||
| z-index: 10; | |||
| width: 24.3rem; | |||
| width: clamp(243px, 50%, 433px); | |||
There was a problem hiding this comment.
please use rem units, in our case 1rem = 10px
Ticket: ENT-9757 Changelog: None Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>
mineralsfree
force-pushed
the
ENT-9757
branch
from
af513e4 to
be9bac2
Compare
Ticket: ENT-9757
Changelog: None