Better prompts and defaults when adding by URL and adding masterfiles via cfbs init #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
olehermanse
commented
May 28, 2024
olehermanse
commented
- cfbs.json: added_by now documents when a masterfiles module was added by "cfbs init"
- cfbs init: Specifically add the masterfiles module from the masterfiles repo URL
- cfbs add: Now adds all modules from URL if user presses enter or passes --non-interactive
- cfbs add: Now skips the prompt if a repo added by URL only has 1 module
- cfbs add: Added information about dependencies when adding modules by URL
- cfbs add: Fixed issue printing empty list of modules before erroring when adding by URL
- cfbs add: Now prompts to add individual modules after user says no to add all from URL
olehermanse
force-pushed
the
master
branch
2 times, most recently
from
482a5f8 to
32400ff
Compare
|
SUBSCRIBED. |
… by "cfbs init" Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
…es repo URL Previously we were telling the add command to add a module from masterfiles repo URL at a specific commit, but not specifying which module to add, resulting in an extra prompt. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
…es --non-interactive Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Ticket: CFE-3863 Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
… URL Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
…when adding by URL Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
… add all from URL Ticket: CFE-4015 Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
nickanderson
approved these changes
May 28, 2024
| prompt_user( | ||
| non_interactive, | ||
| "Specify policy set to use instead (empty to skip)", | ||
| default="", |
There was a problem hiding this comment.
Perhaps an example response. I guess, but am not sure that I should provide a module repo URL and perhaps a module name, maybe a commit sha in the URL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.