cfbs get-input no longer errors for modules which don't support input #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
force-pushed
the
olehermanse-patch-1
branch
from
694cfc2 to
5572b6e
Compare
We use this command to look for input in all modules (before we know that the module supports input or not). Returning empty array makes it easy to see that there is nothing there, without causing errors. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
olehermanse
force-pushed
the
olehermanse-patch-1
branch
from
5572b6e to
28053cb
Compare
craigcomstock
approved these changes
Dec 20, 2022
olehermanse
added a commit
to olehermanse/buildscripts
that referenced
this pull request
Dec 20, 2022
See: cfengine/cfbs#152 Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.