ENT-12668: Fix nt-discovery.sh usage and other improvements #124
+118
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcomstock
force-pushed
the
ENT-12668
branch
2 times, most recently
from
40d2f97 to
7fb0888
Compare
olehermanse
approved these changes
Feb 17, 2025
olehermanse
reviewed
Feb 17, 2025
vpodzime
reviewed
Feb 17, 2025
…r machine These were added to expose bug in how nt-discovery.sh is managed and used. Ticket: ENT-12668
craigcomstock
force-pushed
the
ENT-12668
branch
2 times, most recently
from
4aff441 to
2ec0c38
Compare
vpodzime
reviewed
Feb 19, 2025
craigcomstock
force-pushed
the
ENT-12668
branch
from
2ec0c38 to
c03d17e
Compare
The nt-discovery.sh file was assumed to be in PWD which would almost never be the case except during development. This change required some further refactoring to change put() on UNIX hosts to copy to /tmp since otherwise we don't really know where PWD is reliably. Ticket: ENT-12668
craigcomstock
force-pushed
the
ENT-12668
branch
from
c03d17e to
33a5f39
Compare
larsewi
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially the problem was cf-remote install localhost not working with nt-discovery.sh.
I fixed a few other things I found along the way to improve visibility of what is wrong when ssh/scp don't work and other bits I noticed.