You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If unsupported types are passed to qpack they are silently ignored and a corrupted output produced.
example to reproduce
import qpack, datetime
t = qpack.packb({'d' : datetime.datetime.now()})
qpack.unpackb(t)
From my point of view, this should already fail when packing. I suggest to add something like the following to the end of the _pack function to handle the case where an unsupported type is passed to it:
else:
raise TypeError('%s is not supported for packing with qpack'%(type(obj)))
This will raise a TypeError whenever an unsupported type is passed to the function.
The text was updated successfully, but these errors were encountered:
@pumelo thanks for reporting this issue, as we are currently in the mids of our vacation season our resources are somewhat limited hence the delayed response. My partner @joente will take this forward next week.
If unsupported types are passed to qpack they are silently ignored and a corrupted output produced.
example to reproduce
From my point of view, this should already fail when packing. I suggest to add something like the following to the end of the _pack function to handle the case where an unsupported type is passed to it:
This will raise a TypeError whenever an unsupported type is passed to the function.
The text was updated successfully, but these errors were encountered: