Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use our own boulder rate limit file #9889

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

bmw
Copy link
Member

@bmw bmw commented Feb 7, 2024

Our boulder tests started failing because letsencrypt/boulder#7201 deleted the alternate rate limit policy file. I expect us using our own copy of the file is pretty safe as the files rarely change.

I also tried just using their remaining default test rate limits file, but hit rate limits.

Finally, regardless of what file I used and even if I tried pinning back boulder, the overall docker config seems a bit slower now and requires a higher retry value before we time out waiting for boulder to start.

You can see tests passing with this change at https://dev.azure.com/certbot/certbot/_build/results?buildId=7460&view=results.

ohemorange
ohemorange previously approved these changes Feb 7, 2024
Copy link
Contributor

@ohemorange ohemorange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I have a minor suggestion, take it or leave it

@@ -0,0 +1,54 @@
# See cmd/shell.go for definitions of these rate limits.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# See cmd/shell.go for definitions of these rate limits.
# See https://github.com/letsencrypt/boulder/blob/main/cmd/shell.go for definitions of these rate limits.

or

Suggested change
# See cmd/shell.go for definitions of these rate limits.
# See letsencrypt/boulder/cmd/shell.go for definitions of these rate limits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good idea! I blindly copied the deleted file without even reading it.

os.rename(join(instance_path, 'test/rate-limit-policies-b.yml'),
join(instance_path, 'test/rate-limit-policies.yml'))
ref = importlib_resources.files("certbot_integration_tests")
ref = ref / "assets" / "boulder-rate-limit-policies.yml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so cool!!!!

Copy link
Contributor

@ohemorange ohemorange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ohemorange ohemorange merged commit 8b5a017 into master Feb 8, 2024
16 checks passed
@ohemorange ohemorange deleted the own-boulder-policies branch February 8, 2024 01:33
bmw added a commit that referenced this pull request Feb 8, 2024
Fixes #9892 and https://github.com/certbot/certbot/security/dependabot

Upgrading the base docker image has been done in previous PRs like #9415. Doing this was needed because the [newer versions of `cryptography` need a newer version of rust](https://dev.azure.com/certbot/certbot/_build/results?buildId=7451&view=logs&j=fdd3565a-f3c6-5154-eca9-9ae03666f7bd&t=5dbd9851-46a4-524f-73a8-4028241afcde&l=475).

I ran the full test suite on this branch which you can see in the GitHub status checks below. The boulder tests should fail as they're to be fixed by #9889 but everything else should pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants