Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak JUnit config for e2e / integration tests #551

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Tweak JUnit config for e2e / integration tests #551

merged 2 commits into from
Feb 10, 2025

Conversation

SgtCoDFish
Copy link
Member

@SgtCoDFish SgtCoDFish commented Feb 10, 2025 •
edited
Loading

Fixes a few issues:

  1. Integration test output had "e2e" in it, which is misleading
  2. Integration test output had the same name as the smoke tests, leading to output for one overwriting the other
  3. E2E test JUnit output was configured in both Go code and using CLI flags passed to ginkgo, which led to error messages in smoke tests

Example of smoke test errors (from here):

Could not open /logs/artifacts/test_smoke_junit-go-e2e.xml:
open /logs/artifacts/test_smoke_junit-go-e2e.xml: no such file or directory

@SgtCoDFish
rename integration test junit file to avoid clashes
94997b1 
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@SgtCoDFish
remove in-code artifact definitions to avoid clashing with make
6352c6f 
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2025
erikgb
erikgb reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@cert-manager-prow cert-manager-prow bot merged commit cc20cc3 into cert-manager:main Feb 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtCoDFish @erikgb