Fix issue with updating of JKS/PKCS targets when password changes #449 (review) #480
+364
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com> fix typo in variable name, regenerate API doc Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com> fix bundle test with annotation zero strings Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
cert-manager-prow
bot
added
dco-signoff: yes
cert-manager-prow
bot
added
size/XL
erikgb
reviewed
Nov 21, 2024
There was a problem hiding this comment.
One (hopefully final) suggestion suggestion for renaming vars. Feel free to unhold!
/lgtm
/approve
/hold
Maybe also update the PR description - so that merging this PR will auto-close the issue and original PR by @arsenalzp?
cert-manager-prow
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
pr/arsenalzp/449
branch
from
d9d8cd5 to
7a425f8
Compare
|
New changes are detected. LGTM label has been removed. |
cert-manager-prow
bot
removed
the
lgtm
|
/unhold |
cert-manager-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed #449 and added 2 commits (see their description for details):
Can be added to the original PR or can be merged directly, made sure to keep @arsenalzp as the original PR on the commit.
fixes #433
supersedes #449