test: remove dead event recorder code #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
size/M
erikgb
force-pushed
the
remove-test-unused
branch
from
e208c09 to
eaebb87
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
remove-test-unused
branch
from
eaebb87 to
d763d47
Compare
erikgb
commented
Aug 14, 2024
| case event = <-fakerecorder.Events: | ||
| default: | ||
| } | ||
| assert.Equal(t, test.expEvent, event) |
There was a problem hiding this comment.
Or should we keep this to assert no events?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some dead code while working with #378. Also removing
fakeclientimport alias to avoid clash with variable./cc @inteon