Kubectl plugin for darwin arm64 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
Signed-off-by: irbekrm <irbekrm@gmail.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
irbekrm
force-pushed
the
kubectl_plugin_for_darwin_arm
branch
from
9679c81 to
791347b
Compare
|
Checking the built binary: |
SgtCoDFish
requested changes
Jun 9, 2021
|
|
||
| ### Development | ||
|
|
||
| #### Creating development builds |
There was a problem hiding this comment.
praise: great addition, love it 👌
jetstack-bot
added
dco-signoff: no
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com> Signed-off-by: irbekrm <irbekrm@gmail.com>
irbekrm
force-pushed
the
kubectl_plugin_for_darwin_arm
branch
from
72c9384 to
45a1439
Compare
jetstack-bot
added
dco-signoff: yes
|
/lgtm |
SgtCoDFish
approved these changes
Jun 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 15, 2021
Merged
This was referenced Jun 15, 2021
1 task
1 task
1 task
1 task
This was referenced Jun 19, 2021
This was referenced Jun 28, 2021
This was referenced Jul 16, 2021
1 task
This was referenced Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the release tool to also build the cert-manager kubectl plugin for darwin/arm64.
Since, we already have darwin/arm64 in the list of supported os/arch combinations for the kubectl plugin in cert-manager codebase here this was just a matter of ensuring that we build the release artifacts with
--platforms=@io_bazel_rules_go//go/toolchain:darwin_arm64flag fromcmrel.I have also updated the README and
cmrel stage --helpoutput a little.I've created a 'development' build with the updated
cmreltool here https://console.cloud.google.com/storage/browser/cert-manager-release/stage/gcb/devel/5875c828c68b9e22ec157508743e360017916190?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&authuser=1&project=cert-manager-release&prefix=&forceOnObjectsSortingFiltering=false - if anyone M1 Mac felt like trying this out 😅Fixes #25 , cert-manager/cert-manager#4052