Release cert manager 1.14 #105
Conversation
jetstack-bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
size/XL
wallrj
force-pushed
the
release-cert-manager-1.14.1
branch
2 times, most recently
from
93f8f00 to
850dbf7
Compare
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
…he webhook Signed-off-by: Richard Wall <richard.wall@venafi.com>
wallrj
force-pushed
the
release-cert-manager-1.14.1
branch
from
850dbf7 to
2b98c7e
Compare
And explain why Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
| # repository. See: | ||
| # * https://redhat-connect.gitbook.io/certified-operator-guide/ocp-deployment/operator-metadata/bundle-directory/managing-openshift-versions | ||
| # * https://redhat-openshift-ecosystem.github.io/community-operators-prod/packaging-required-criteria-ocp/#configure-the-openshift-distribution | ||
| # * https://github.com/redhat-openshift-ecosystem/operator-pipelines/pull/562 |
There was a problem hiding this comment.
There was a problem hiding this comment.
Compute the BUNDLE_CHANNELS and DEFAULT_CHANNEL variables. And document each of the variables explaining which ones should and which should not be modified by the release manager. Explain the desired channel allocation behaviour. Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
wallrj
changed the title
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
| # | ||
| # See README.md#Release Process for more details. | ||
| CERT_MANAGER_VERSION ?= 1.14.2 | ||
| export BUNDLE_VERSION ?= $(CERT_MANAGER_VERSION) |
There was a problem hiding this comment.
I took the opportunity to improve the documentation of these variables and attempted to explain how they are intended to be used.
| BUNDLE_CHANNELS := $(strip $(if $(subst ${CERT_MANAGER_VERSION},${empty},${BUNDLE_VERSION}),,stable) candidate) | ||
| # STABLE_CHANNEL is the default channel for the bundle. By default it will be the first of the BUNDLE_CHANNELS, | ||
| # so make sure that the `stable` channel appears first in that list if it is present. | ||
| STABLE_CHANNEL := $(firstword $(BUNDLE_CHANNELS)) |
There was a problem hiding this comment.
These variables are once again computed. And I've documented the intended behaviour.
They were originally computed, but I had to override them for a release which went wrong and only now have I re-instated the original behaviour.
| * (final release only ) | ||
| * Remove the `-rc1` suffix from `BUNDLE_VERSION` | ||
| * Set `BUNDLE_CHANNELS ?= candidate stable` |
There was a problem hiding this comment.
The BUNDLE_CHANNELS variable is now computed based on the presence of a pre-release suffix on the BUNDLE_VERSION variable. So it's no longer necessary to edit this for each release.
| "--tls-cert-file", | ||
| "--tls-private-key-file", | ||
| )) | ||
| ] | ||
| # Add the arguments back with the modified values | ||
| args.extend([ | ||
| "--dynamic-serving-dns-names=cert-manager-webhook-service.$(POD_NAMESPACE).svc", |
There was a problem hiding this comment.
I don't know why I left this particular argument in previous releases, but in 1.14 it is no longer allowed to mix the dynamic and the static certificate arguments, so I've removed it.
jetstack-bot
removed
the
do-not-merge/work-in-progress
This was originally going to be the release of cert-manager 1.14.1, but while I was working on it and waiting for the operatorhub CI pipeline admins to help me get that version merged, 1.14.2 was released, so this is PR has published three new bundles to operatorhubs:
I've included diffs between these and the last 1.13.3 release as gists in the comments below.
v1.14.2
Testing
On OpenShift 4.14
v1.14.2-rc1
v1.14.1-rc1