Update all the tools and get make bundle-test working in GitHub Actions
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
jetstack-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
size/M
wallrj
commented
Feb 6, 2024
| @@ -25,17 +25,18 @@ help: ## Display this help | |||
| @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m<target>\033[0m\n\nTargets:\n"} /^[0-9a-zA-Z_-]+:.*?##/ { printf " \033[36m%-20s\033[0m %s\n", $$1, $$2 }' $(MAKEFILE_LIST) | |||
|
|
|||
| OLM_PACKAGE_NAME ?= cert-manager | |||
| IMG_BASE ?= gcr.io/jetstack-richard/cert-manager | |||
| IMG_BASE_DEFAULT := ttl.sh/$(shell uuidgen)/cert-manager | |||
| IMG_BASE ?= $(IMG_BASE_DEFAULT) | |||
There was a problem hiding this comment.
Needed IMG_BASE_DEFAULT (set using := syntax) so that IMG_BASE remains constant across all the rules in the Makefile.
Otherwise uuidgen is executed every time the variable is used.
Makefile
Outdated
| ${cmctl}: | ||
| mkdir -p $(dir $@) | ||
| curl -fsSL ${url} | tar --directory $(dir $@) -xzf - cmctl | ||
| mv $(dir $@)/cmctl $@ |
There was a problem hiding this comment.
Install cmctl for access to the cmctl check api feature.
| # | ||
| # Also works around a bug in `cmctl check api`, where it will return success if | ||
| # the CRDs are installed but the webhook has not been configured. See | ||
| # https://github.com/cert-manager/cert-manager/issues/6721 |
There was a problem hiding this comment.
| # https://github.com/cert-manager/cert-manager/issues/6721 | ||
| # | ||
| # Use process substitution instead of pipe, otherwise kubectl get --watch may hang. See | ||
| # https://stackoverflow.com/a/53382807 |
There was a problem hiding this comment.
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Allow bundle-test to build and test the bundle sources that are committed, rather than attempting to regenerate them every time. Allows bundle-test to run in GitHub Actions and test exactly what bundle sources are checked in Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
jetstack-bot
added
size/L
wallrj
commented
Feb 7, 2024
| > image to be preloaded into the Kubernetes clusters. | ||
| > See: | ||
| > - https://github.com/cert-manager/cert-manager/pull/6387 | ||
| > - https://github.com/cert-manager/cert-manager/pull/6391 |
There was a problem hiding this comment.
wallrj
changed the title
make bundle-test working againmake bundle-test working in GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded all the tools in the Makefile and made some changes to get
make bundle-testworking again.And I've set up GitHub Actions to run
make bundle-testfor every PR.This should give some additional assurance that the committed bundle sources are usable.
Testing