Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#128, #117) Improve logging and add availability field #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yuvrajsinghspd09
Copy link

  1. Improved logging output structure for better readability and maintainability (fixtures: prettify output message structure #128).
  2. Added an optional "availability" field to dataset records with statuses: Available, Sample available, and Needs to be requested (Add a new field: availability #117).

@psaiz
Copy link
Contributor

psaiz commented Jan 31, 2025

Hi @Yuvrajsinghspd09.
Thanks for the pull request. One of the two tasks that you picked (#117) is a bit trickier, and it needs more internal discussions. If you don't mind, I would prefer to leave that one out of the scope of this PR.
The PR also seems to add some files that are not necessary. Could you please check that?
Finally, would you mind checking also the comments about the verbose level (changing the logging to DEBUG), and the final summary?

Thanks again,
pablo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants