Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymorphic types override per relationship #1440

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

lgebhardt
Copy link
Member

Allow relationship to set the polymorphic types

Warn when eager loading is disabled, which results in not being able to detect the types.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt requested a review from bf4 January 26, 2024 15:15
@lgebhardt lgebhardt force-pushed the v0-11-dev-polymorphic-override branch from 58c81d3 to 23cbc50 Compare January 26, 2024 17:17
@@ -19,8 +19,12 @@ class Railtie < ::Rails::Railtie
}
end

initializer "jsonapi_resources.initialize", after: :initialize do
JSONAPI::Utils::PolymorphicTypesLookup.polymorphic_types_lookup_clear!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine

Copy link
Collaborator

@bf4 bf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lgebhardt lgebhardt merged commit f75acdb into v0-11-dev Jan 26, 2024
54 of 78 checks passed
@lgebhardt lgebhardt deleted the v0-11-dev-polymorphic-override branch January 26, 2024 17:37
lgebhardt added a commit that referenced this pull request Apr 18, 2024
* Add warning about disabling eager loading

* Fix overriding polymorphic types on a relationship
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants