Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-erce non-present values like false to string #1387

Open
wants to merge 1 commit into
base: release-0-9
Choose a base branch
from

Conversation

bf4
Copy link
Collaborator

@bf4 bf4 commented Apr 20, 2022

We have a resource which calls another resource, and specifically calls 'verify_filters'. We discovered that in 0.9 and 0.10 verify_filter calls raw.present? which is false when raw is false. This change makes the processing of the true and false consistent.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@bf4 bf4 force-pushed the correct_verify_filter branch from f181f59 to 4b9d7c2 Compare April 20, 2022 14:30
@bf4 bf4 force-pushed the correct_verify_filter branch from 4b9d7c2 to 0e0c4e5 Compare April 20, 2022 14:31
raw = "false"
else
nil # no-op
end
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgebhardt any objection to this? otherwise false is treated as not present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant