Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize eth_getBlockByNumber and eth_getBlockByHash implementations #187

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Optimize eth_getBlockByNumber and eth_getBlockByHash implementations #187

merged 3 commits into from
Aug 23, 2022

Conversation

prathamesh0
Copy link
Contributor

@prathamesh0 prathamesh0 commented Aug 19, 2022 •
edited
Loading

Part of #186
Handles todo: https://github.com/vulcanize/ipld-eth-server/blob/release-v4.1.4-alpha/pkg/eth/backend.go#L315

  • Use joins instead of firing queries in two steps and in a loop
  • Use a DB transaction to all queries in an API call
  • Upgrade ipfs-ethdb to v4.0.6-alpha

@prathamesh0 prathamesh0 self-assigned this Aug 19, 2022
@prathamesh0 prathamesh0 changed the title Optimize eth_getBlockByNumber and eth_getBlockByHash implementations [WIP] Optimize eth_getBlockByNumber and eth_getBlockByHash implementations Aug 19, 2022
@prathamesh0 prathamesh0 changed the title [WIP] Optimize eth_getBlockByNumber and eth_getBlockByHash implementations Optimize eth_getBlockByNumber and eth_getBlockByHash implementations Aug 23, 2022
@ashwinphatak ashwinphatak merged commit e40e8a7 into v4 Aug 23, 2022
@ashwinphatak ashwinphatak deleted the pm-optimize-getblock branch August 23, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinphatak ashwinphatak Awaiting requested review from ashwinphatak

Assignees

@prathamesh0 prathamesh0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prathamesh0 @ashwinphatak