Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #29

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

aschmahmann
Copy link
Collaborator

Update dependencies

Description

  • Updates the base dependencies across patch and minor version changes (including a rename of go-jose which was moved to a different package name)
  • Updates go-jose to v4
  • Updates the rapid package and the associated tests to v1

The motivation is that some of the underlying dependencies are very out of date notably including go-jose which has been archived and is two major versions behind. If dropping the testing changes associated with updating rapid is desirable that's IMO totally acceptable.

I'd also appreciate if this package could be tagged after merging

How Has This Been Tested?

So far only unit tests in this repo. I'm happy to test by bubbling up to kubo as well, but I suspect the test coverage here will handle most of the work.

Definition of Done

Before submitting this PR, please make sure:

  • The work addresses the description and outcomes in the issue
  • [ ] I have added relevant tests for new or updated functionality
  • My code follows conventions, is well commented, and easy to understand
  • My code builds and tests pass without any errors or warnings
  • I have tagged the relevant reviewers
  • [ ] I have updated the READMEs of affected packages
  • [ ] I have made corresponding changes to the documentation
  • The changes have been communicated to interested parties
    • This PR serves as the notification, if there's anything else I should do let me know

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

@aschmahmann
Copy link
Collaborator Author

cc @smrz2001 @warpfork, but maybe someone else is better to review here

Copy link
Collaborator

@smrz2001 smrz2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aschmahmann aschmahmann merged commit 61df42e into ceramicnetwork:main Nov 4, 2024
@aschmahmann aschmahmann deleted the chore/update-deps branch November 4, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants