Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: Fix global image status listing #924

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

diffs
Copy link
Contributor

@diffs diffs commented Sep 29, 2023

Running MirrorImageGlobalStatusList returns a slice of GlobalMirrorImageIDAndStatus. The IDs are all different, however, the GlobalMirrorImageStatus is set to the 1st one for each image. This makes the status data inaccurate for every image after the 1st, including the image's name, GlobalID, and mirror status.

Signed-off-by: Daniel R <github@dann.me>
Signed-off-by: Daniel R <github@dann.me>
@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Sep 30, 2023
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks very much for the fix!

@mergify mergify bot merged commit e173115 into ceph:master Oct 2, 2023
15 checks passed
@diffs diffs deleted the fix-global-image-status-listing branch October 2, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants