rbd: add functions to parse json in mirroring status description field #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
force-pushed
the
jjm-rdb-desc-status
branch
from
649020a
to
a4adb28
Compare
|
@yati1998 here's a draft PR for issue #841 the api extensions to get rbd snapshot mirroring stats to the API. If you think this is sufficient for the needs of csi-addons please let me know and I will move the PR to reviewable state and request reviews. If I hear no feedback for about a week or so I'll just request reviews anyway. Thanks! |
|
Yeah, that should be fine. Thank you @phlogistonjohn |
anoopcs9
requested changes
Mar 16, 2023
Add UnmarshalDescriptionJSON method to SiteMirrorImageStatus Add DescriptionReplayStatus method to SiteMirrorImageStatus Both these functions are meant to help extract the JSON object that is some times appended to the Description field in the SiteMirrorImageStatus struct. I have only seen the JSON appear after "replaying, " but there's little docs for this and I skimmed to code to even find out what fields the JSON might include. As such, the UnmarshalDescriptionJSON tries to unmarshal the appended JSON into an object the caller provides in case skimming the code was insufficient or the caller has other needs. For most cases, DescriptionReplayStatus can be used to parse the JSON into a struct containing known fields. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Add unit and simplistic functional tests for new JSON/status description extraction functions. Because these are preview functions we also add a stub file to add a no-op function to be built on non-preview builds. This avoids having to reimplement large parts of the existing mirroring tests just to validate this small aspect of the SiteMirrorImageStatus struct. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
It is doubtful that these Print(f)s have been useful to any one for a long time. Remove them. Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-rdb-desc-status
branch
from
a4adb28
to
0139940
Compare
anoopcs9
added
the
API
ansiwen
reviewed
Mar 17, 2023
| if end == -1 { | ||
| return "", ErrNotExist | ||
| } | ||
| if start >= end { |
There was a problem hiding this comment.
cannot be equal. ;-) (not a serious comment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #841
Add UnmarshalDescriptionJSON method to SiteMirrorImageStatus
Add DescriptionReplayStatus method to SiteMirrorImageStatus
Both these functions are meant to help extract the JSON object that is some times appended to the Description field in the SiteMirrorImageStatus struct. I have only seen the JSON appear after "replaying, " but there's little docs for this and I skimmed to code to even find out what fields the JSON might include. As such, the UnmarshalDescriptionJSON tries to unmarshal the appended JSON into an object the caller provides in case skimming the code was insufficient or the caller has other needs. For most cases, DescriptionReplayStatus can be used to parse the JSON into a struct containing known fields.
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.