rgw: use maintained github.com/aws/aws-sdk-go-v2 module instead of v1

[nixpanic]

github.com/aws/aws-sdk-go is deprecated and will be end-of-life later in
2025. github.com/aws/aws-sdk-go-v2 is the replacement, but using it
requires a few minor adaptions.

Also update the go version in go.mod, as go1.19 is not supported anymore, and certain packages (at least
aws-sdk-go-v2) require go1.21 or newer.

Closes: #1053

[phlogistonjohn]

Would it be a big pain to either split the PR or reorganize it so that the Go 1.21 changes come first (and are combined)? That way we'd be more future bisect friendly. (this is my exception to the rule that patches should be as small as reasonably possible )

I'm assuming that the new aws library requires the change to the go <ver> line of the Go file?

[nixpanic]

Would it be a big pain to either split the PR or reorganize it so that the Go 1.21 changes come first (and are combined)? That way we'd be more future bisect friendly. (this is my exception to the rule that patches should be as small as reasonably possible )

Sure, I can do that.

I'm assuming that the new aws library requires the change to the go <ver> line of the Go file?

That is my assumption as well. Evey time I undid the change, it popped up after running make test-container.

[phlogistonjohn]

Would it be a big pain to either split the PR or reorganize it so that the Go 1.21 changes come first (and are combined)? That way we'd be more future bisect friendly. (this is my exception to the rule that patches should be as small as reasonably possible )

Sure, I can do that.

TY!

I'm assuming that the new aws library requires the change to the go <ver> line of the Go file?

That is my assumption as well. Evey time I undid the change, it popped up after running make test-container.

OK. Thanks for verifying!

[nixpanic]

@phlogistonjohn is this sortof how you were expecting it?

[phlogistonjohn]

Yes thanks. Changes & code LGTM.

I've set extended review on this because I do want at least a 2nd set of eyes to review.