Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw/admin: support new-bucket-name for LinkBucket #1046

Merged
merged 1 commit into from
Jan 7, 2025
Merged

rgw/admin: support new-bucket-name for LinkBucket #1046

merged 1 commit into from
Jan 7, 2025

Conversation

sj14
Copy link
Contributor

@sj14 sj14 commented Nov 26, 2024 •
edited by anoopcs9
Loading

Adding the new-bucket-name parameter to BucketLinkInput which allows renaming a specific bucket.

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@sj14 sj14 force-pushed the sj/link-new-bucket-name branch 7 times, most recently from f173e16 to 01c4a18 Compare November 28, 2024 13:40
@sj14 sj14 marked this pull request as ready for review November 28, 2024 14:06
@sj14 sj14 force-pushed the sj/link-new-bucket-name branch 3 times, most recently from e9005b2 to 26f1b1d Compare December 16, 2024 11:51
anoopcs9
anoopcs9 previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Dec 16, 2024
phlogistonjohn
phlogistonjohn reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but I certainly find the rgw stuff my weakest go-ceph area.
@anoopcs9 do you want to try and take #1051 first and then retest this one with a "fixed" CI first?

@anoopcs9
Copy link
Collaborator

Generally LGTM, but I certainly find the rgw stuff my weakest go-ceph area.

Adding our usual goto as an additional reviewer 😄

@anoopcs9 do you want to try and take #1051 first and then retest this one with a "fixed" CI first?

Sure.

@anoopcs9 anoopcs9 requested a review from thotz December 16, 2024 15:39
@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented Dec 17, 2024

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the sj/link-new-bucket-name branch from 26f1b1d to 28ba7bc Compare December 17, 2024 08:29
@mergify Mergify
Copy link

mergify bot commented Dec 27, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@sj14 sj14 force-pushed the sj/link-new-bucket-name branch from 28ba7bc to e3cdfce Compare December 30, 2024 11:53
@mergify mergify bot dismissed anoopcs9’s stale review December 30, 2024 11:54

Pull request has been modified.

@sj14
Copy link
Contributor Author

sj14 commented Dec 30, 2024

Is there anything I can help with to get this merged?

anoopcs9
anoopcs9 approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything I can help with to get this merged?

Sorry for the long wait(christmas and year end holidays). I'm hopeful that we can get this merged very soon.

@mergify Mergify
Copy link

mergify bot commented Jan 7, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Jan 7, 2025

@Mergifyio rebase

@sj14 @anoopcs9
rgw/admin: support new-bucket-name for LinkBucket
081e774 
Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>
@mergify Mergify
Copy link

mergify bot commented Jan 7, 2025

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the sj/link-new-bucket-name branch from e3cdfce to 081e774 Compare January 7, 2025 10:11
@mergify mergify bot merged commit 70fd8f1 into ceph:master Jan 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn left review comments

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@thotz thotz thotz approved these changes

Assignees
No one assigned
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sj14 @anoopcs9 @thotz @phlogistonjohn