server: Don't mute exceptions

[epuertat]

Fixes: #97

From https://docs.python.org/3/reference/datamodel.html#object.__exit__:

object.__exit__(self, exc_type, exc_value, traceback)

(...)

If an exception is supplied, and the method wishes to suppress the exception
(i.e., prevent it from being propagated), it should return a true value.
Otherwise, the exception will be processed normally upon exit from this method.

[idryomov]

fix(server): Don't mute exceptions

None of the existing commits use this (conventional commits?) style. If we wanted to adopt it, it's probably fine but this needs to be discussed and made explicit since nothing else in Ceph uses it today.

[epuertat]

fix(server): Don't mute exceptions

None of the existing commits use this (conventional commits?) style. If we wanted to adopt it, it's probably fine but this needs to be discussed and made explicit since nothing else in Ceph uses it today.

Agree @idryomov. I'll fix this and propose this topic for the next Tuesday (although it overlaps with Cephalocon).

My rationale here is that given we're a separate repo from ceph/ceph, I assume that we would keep a separate versioning scheme as well. And as we rely on a gRPC schema and 2 other integration pieces (SPDK and Ceph repos) that might require a thorough cross-dependency versioning.

Here I thought that conventional commits (and semantic versioning, which we're not following in ceph/ceph) might help manage release numbering and deal with breaking changes across the multiple repos involved. I'd also facilitate creating release notes/changelogs.

[idryomov]

propose this topic for the next Tuesday (although it overlaps with Cephalocon).

Yeah, not sure if we are having a meeting next Tuesday...

[epuertat]

@idryomov I addressed both comments.