nvme_gw: allow to list and delete bdevs and subsystems #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitashekar
reviewed
Nov 29, 2021
nvme_gw_server.py
Outdated
| def bdev_rbd_delete(self, request, context): | ||
| # Delete bdev | ||
| self.logger.info({ | ||
| f"Received: {request.bdev_name}", |
There was a problem hiding this comment.
nit: it would be nice to note that the request was to delete the bdev in the log
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
trociny
force-pushed
the
wip-list-delete
branch
from
f1b9f82 to
1519ed4
Compare
|
@anitashekar Thanks! Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple implementation to add the ability to list and delete bdevs and subsystems. It will need to be improved when we have a better understanding about the UI/API.