Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: add image size in toSnapshot (backport #4791) #4795

Merged
merged 1 commit into from
Aug 22, 2024
Merged

rbd: add image size in toSnapshot (backport #4791) #4795

merged 1 commit into from
Aug 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 21, 2024

we need to return the rbd image size as a snapshot size in CreateSnapshot Response.

fixes: #4788

This is an automatic backport of pull request #4791 done by [Mergify](https://mergify.com).

@mergify mergify bot added ok-to-test Label to trigger E2E tests component/rbd Issues related to RBD labels Aug 21, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 21, 2024
@Rakshith-R
Copy link
Contributor

/retest ci/centos/mini-e2e-helm/k8s-1.29

@nixpanic
Copy link
Member

@Mergifyio rebase

@Madhu-1 @nixpanic
rbd: add image size in toSnapshot
9e18721 
we need to return the rbd image size
as a snapshot size in CreateSnapshot
Response.

fixes: #4788

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 38fd27a)
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 22, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the mergify/bp/release-v3.12/pr-4791 branch from e3d4f57 to 9e18721 Compare August 22, 2024 08:25
@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 22, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Aug 22, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 22, 2024
@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e/k8s-1.30

@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e/k8s-1.30

[FAILED] backend images not matching kubernetes resource count,image count 1 kubernetes resource count 0

logs

@nixpanic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 22, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 02a7994 into release-v3.12 Aug 22, 2024
38 checks passed
@mergify mergify bot deleted the mergify/bp/release-v3.12/pr-4791 branch August 22, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceph-csi-bot @Rakshith-R @nixpanic @Madhu-1