Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: proposal for providing PV key rotation #4655

Merged
merged 2 commits into from
Jul 19, 2024
Merged

docs: proposal for providing PV key rotation #4655

merged 2 commits into from
Jul 19, 2024

Conversation

black-dragon74
Copy link
Member

The design and implementation details for rotating the encryption keys for volumes.

@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Jun 3, 2024
Rakshith-R
Rakshith-R previously requested changes Jun 4, 2024
View reviewed changes
docs/design/proposals/pv-key-rotation.md Outdated Show resolved Hide resolved
docs/design/proposals/pv-key-rotation.md Outdated Show resolved Hide resolved
docs/design/proposals/pv-key-rotation.md Outdated Show resolved Hide resolved
Madhu-1
Madhu-1 requested changes Jun 4, 2024
View reviewed changes
docs/design/proposals/pv-key-rotation.md Outdated Show resolved Hide resolved
docs/design/proposals/pv-key-rotation.md Outdated Show resolved Hide resolved
@Rakshith-R Rakshith-R mentioned this pull request Jun 10, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 5, 2024
@nixpanic nixpanic mentioned this pull request Jul 12, 2024
Merged
@black-dragon74 black-dragon74 requested a review from Madhu-1 July 15, 2024 10:09
Madhu-1
Madhu-1 reviewed Jul 15, 2024
View reviewed changes
docs/design/proposals/rbd-pv-key-rotation.md Outdated Show resolved Hide resolved
docs/design/proposals/rbd-pv-key-rotation.md Outdated Show resolved Hide resolved
docs/design/proposals/rbd-pv-key-rotation.md Outdated Show resolved Hide resolved
@Madhu-1 Madhu-1 requested a review from nixpanic July 15, 2024 10:54
@github-actions github-actions bot removed the stale label Jul 15, 2024
@black-dragon74 black-dragon74 force-pushed the doc-add-pvkr branch 3 times, most recently from 999bbfc to 3b53269 Compare July 16, 2024 12:07
Madhu-1
Madhu-1 previously approved these changes Jul 16, 2024
View reviewed changes
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 16, 2024

@black-dragon74 please fix the CI failures

@mergify mergify bot dismissed Madhu-1’s stale review July 16, 2024 12:43

Pull request has been modified.

@black-dragon74 black-dragon74 force-pushed the doc-add-pvkr branch 2 times, most recently from b776257 to d1c3689 Compare July 17, 2024 10:21
@nixpanic nixpanic dismissed Rakshith-R’s stale review July 19, 2024 07:09

Looks like Rakshiths comments have been addressed.

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 19, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 64c5be5

@black-dragon74
doc: proposal for providing PV key rotation
10d9712 
The design and implementation details for rotating
the encryption keys for volumes.

Signed-off-by: black-dragon74 <niryadav@redhat.com>
@black-dragon74
doc: Update docs for rbd-pv-key-rotation
c1e2b48 
This commit updates the key rotation docs with the following changes:

- Do not call LuksVerify
- Mention specifics of RWX volumes
- Rename the file to represent RBD backed volumes

Signed-off-by: black-dragon74 <niryadav@redhat.com>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jul 19, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jul 19, 2024
@mergify mergify bot merged commit 64c5be5 into ceph:devel Jul 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R left review comments

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@black-dragon74 @Madhu-1 @nixpanic @ceph-csi-bot @Rakshith-R