ci: make minikube.sh work on macOS M1 with the qemu2 driver #4368
Conversation
|
Please update commit message type from scripts to ci and reduce the length of body's line to max 80 chars by splitting into a new line, to make the checks passed. |
|
Have you tested this out? |
It works for my MBP M1 with macOS Monterey and minikube v1.32.0, but I haven't tested it on linux systems. |
zjx20
changed the title
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
Deploying in the CI still works 👍 I can not test this on a Mac, ideally someone else tries it out before this gets merged. |
|
Thank you @nixpanic. I hope someone will kindly try this branch on macOS M1 and give some feedback. Here are the instructions: export KUBE_VERSION=v1.28.3 # it's the latest version supported by minikube v1.32.0.
export MINIKUBE_ARCH=arm64
export VM_DRIVER=qemu2 # hyperkit is unavailable for arm64, so qemu2 is the only option for macOS M1
export CNI=auto
export RESOLV_CONF=/etc/resolv.conf
export CPUS=4 # "nproc" is unavailable on macOS, so explicitly set a number
export MEMORY=4096
export DISK_SIZE=20
./scripts/minikube.sh up
./scripts/minikube.sh deploy-rook |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
nixpanic
added
keepalive
|
@zjx20 Please use GNU sed on macOS. It will ensure compatibility of the script and will avoid the macOS specific changes (like adding extensions for inline replacements) And then update this PR with Regards |
zjx20
force-pushed
the
devel
branch
2 times, most recently
from
25dc921 to
e2d2a63
Compare
Hi @black-dragon74, I have reverted the changes related to the sed command and updated the PR description. Please take a look. |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
Thank you! Looks good to me. |
|
@Mergifyio rebase |
To utilize minikube on macOS M1, the qemu2 VM driver is currently the only viable option. Therefore, the following modifications have been implemented: * the RESOLV_CONF variable has been made configurable because it needs to be overridden as /etc/resolv.conf when using the qemu2 driver. * adding additional disks when using the qemu2 driver. Signed-off-by: zjx20 <zhoujianxiong2@gmail.com>
✅ Branch has been successfully rebased |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4992644 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
Describe what this PR does
This PR makes scripts/minikube.sh work on macOS M1 with the qemu2 driver.
To utilize minikube on macOS M1, the qemu2 VM driver is currently the only viable option. Therefore, the following modifications have been implemented:
Also, the GNU sed should be used.
Here is the usage example:
Related issues
No.
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)