Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: add default false value for --enable-read-affinity #4298

Merged
merged 1 commit into from
Dec 6, 2023
Merged

helm: add default false value for --enable-read-affinity #4298

merged 1 commit into from
Dec 6, 2023

Conversation

iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Dec 4, 2023 •
edited
Loading

Describe what this PR does

we had missed adding default false value for --enable-read-affinity flag in nodeplugin-daemonset templates.
This is causing the containers CrashLoopBackoff.
This commit fixes the issue by adding the default value as false.

Related issues

Fixes: #4297

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar iPraveenParihar self-assigned this Dec 4, 2023
@mergify mergify bot added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Dec 4, 2023
@nixpanic nixpanic added the backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch label Dec 5, 2023
@Rakshith-R
Copy link
Contributor

@Mergifyio rebase
@Mergifyio queue

@iPraveenParihar @Rakshith-R
helm: add default false value for --enable-read-affinity
c7c31c9 
Signed-off-by: Praveen M <m.praveen@ibm.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

nixpanic commented Dec 6, 2023

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

nixpanic commented Dec 6, 2023

@Mergifyio rebase
@Mergifyio queue

This doesn't work. You need to wait with the queue command until the rebase is finished.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 6, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 6, 2023
@nixpanic nixpanic added the ci/retry/e2e Label to retry e2e retesting on approved PR's label Dec 6, 2023
@nixpanic
Copy link
Member

nixpanic commented Dec 6, 2023

many CI jobs failed to checkout the repository, added the ci/retry/e2e label to have them automatically re-run.

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

@iPraveenParihar "ci/centos/mini-e2e-helm/k8s-1.26" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

@iPraveenParihar "ci/centos/upgrade-tests-rbd" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

@iPraveenParihar "ci/centos/mini-e2e-helm/k8s-1.27" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

@iPraveenParihar "ci/centos/k8s-e2e-external-storage/1.26" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

@iPraveenParihar "ci/centos/mini-e2e/k8s-1.26" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

@iPraveenParihar "ci/centos/mini-e2e-helm/k8s-1.28" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

@iPraveenParihar "ci/centos/mini-e2e/k8s-1.28" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

@iPraveenParihar "ci/centos/mini-e2e/k8s-1.27" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@remisauvat remisauvat mentioned this pull request Dec 6, 2023
Closed
@mergify mergify bot merged commit 2309168 into ceph:devel Dec 6, 2023
38 checks passed
@mergify mergify bot mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@nixpanic nixpanic nixpanic approved these changes

@riya-singhal31 riya-singhal31 Awaiting requested review from riya-singhal31

Assignees

@iPraveenParihar iPraveenParihar

Labels
backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch ci/retry/e2e Label to retry e2e retesting on approved PR's component/deployment Helm chart, kubernetes templates and configuration Issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Chart 3.10.0: csi-rbdplugin container enters CrashLoopBackoff with invalid boolean value error
4 participants
@iPraveenParihar @Rakshith-R @nixpanic @ceph-csi-bot