merge queue: embarking release-v3.9 (d6d66d5) and #3964 together #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
When a volume has AccessType=Block and is encrypted with LUKS, a resize of the filesystem on the (decrypted) block-device is attempted. This should not be done, as the application that requested the Block volume is the only authoritive reader/writer of the data. In particular VirtualMachines that use RBD volumes as a disk, usually have a partition table on the disk, instead of only a single filesystem. The `resizefs` command will not be able to resize the filesystem on the block-device, as it is a partition table. When `resizefs` fails during NodeStageVolume, the volume is unstaged and an error is returned. Resizing an encrypted block-device requires `cryptsetup resize` so that the LUKS header on the RBD-image is updated with the correct size. But there is no need to call `resizefs` in this case. Fixes: #3945 Signed-off-by: Niels de Vos <ndevos@ibm.com> (cherry picked from commit f60a358)
ceph-csi-bot
added
component/rbd
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull request #3964 which was ahead in the queue has been dequeued. ✨
Branch release-v3.9 (d6d66d5) and #3964 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #3964.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by>=1[🛡 GitHub branch protection]resizefson an encrypted BlockMode volume (backport #3958) #3964status-success=ci/centos/k8s-e2e-external-storage/1.25status-success=ci/centos/k8s-e2e-external-storage/1.26status-success=ci/centos/k8s-e2e-external-storage/1.27status-success=ci/centos/mini-e2e-helm/k8s-1.25status-success=ci/centos/mini-e2e-helm/k8s-1.26status-success=ci/centos/mini-e2e-helm/k8s-1.27status-success=ci/centos/mini-e2e/k8s-1.25status-success=ci/centos/mini-e2e/k8s-1.26status-success=ci/centos/mini-e2e/k8s-1.27status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildbase~=^(devel)|(release-.+)$base=ci/centosstatus-success=ci/centos/jjb-validatestatus-success=ci/centos/job-validation#changes-requested-reviews-by=0[🛡 GitHub branch protection]resizefson an encrypted BlockMode volume (backport #3958) #3964Visit the Mergify Dashboard to check the state of the queue
default.More information about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com