ci: use internal minikube extra disks functionality #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minikube from v1.23.0 supports adding extra disks in kvm2 and hyperkit VM drivers. This commit makes use of that functionality and removes steps to attack disks externally. Signed-off-by: Rakshith R <rar@redhat.com>
Madhu-1
reviewed
Sep 7, 2021
Yes, I'll ask mergifyio to create backport prs and add depends-on those prs to be merged. |
Madhu-1
approved these changes
Sep 8, 2021
Madhu-1
requested changes
Sep 8, 2021
|
#2498 fix is backported and merged in all active branches, PTAL |
Madhu-1
approved these changes
Sep 14, 2021
Madhu-1
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minikube from v1.23.0 supports adding extra disks in
kvm2 and hyperkit VM drivers. This commit makes use of
that functionality and removes steps to attack disks
externally.
Depends-on: #2491
Depends-on: #2492
Depends-on: #2498
Signed-off-by: Rakshith R rar@redhat.com