Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: update updateStrategy (backport #2351) #2370

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 5, 2021

This is an automatic backport of pull request #2351 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Aug 5, 2021
@nixpanic
Copy link
Member

nixpanic commented Aug 6, 2021

Rebase this once #2363 is merged to prevent unneeded CI runs

@nixpanic
Copy link
Member

nixpanic commented Aug 6, 2021

@Mergifyio rebase

Update ceph-csi-rbd.provisioner updatestrategy
to allow maxUnavailable pods at a time to be 50%

Signed-off-by: Yug Gupta <yuggupta27@gmail.com>
(cherry picked from commit ea088d4)
Update ceph-csi-cephfs.provisioner updatestrategy
to allow maxUnavailable pods at a time to be 50%

Signed-off-by: Yug Gupta <yuggupta27@gmail.com>
(cherry picked from commit 080f753)
@leseb leseb force-pushed the mergify/bp/release-v3.4/pr-2351 branch from 3d20c7f to 89ecfb6 Compare August 6, 2021 09:45
@mergify
Copy link
Contributor Author

mergify bot commented Aug 6, 2021

Command rebase: success

Branch has been successfully rebased

@nixpanic
Copy link
Member

nixpanic commented Aug 6, 2021

/retest ci/centos/mini-e2e-helm/k8s-1.19

@nixpanic
Copy link
Member

nixpanic commented Aug 6, 2021

/retest ci/centos/mini-e2e/k8s-1.21

@nixpanic
Copy link
Member

nixpanic commented Aug 6, 2021

/retest ci/centos/mini-e2e-helm/k8s-1.19

Helm deployment failed (logs):

+ ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no root@n36.dusty.ci.centos.org 'cd /opt/build/go/src/github.com/ceph/ceph-csi && ./scripts/install-helm.sh install-cephcsi --namespace '\''cephcsi-e2e-44829595b771'\'' --deploy-sc --deploy-secret'
Warning: Permanently added 'n36.dusty.ci.centos.org,172.19.2.100' (ECDSA) to the list of known hosts.
node/minikube labeled
node/minikube labeled
Error from server: etcdserver: request timed out
error executing jsonpath "{.items[0].metadata.name}": Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:
	template was:
		{.items[0].metadata.name}
	object given to jsonpath engine was:
		map[string]interface {}{"apiVersion":"v1", "items":[]interface {}{}, "kind":"List", "metadata":map[string]interface {}{"resourceVersion":"", "selfLink":""}}

@nixpanic
Copy link
Member

nixpanic commented Aug 6, 2021

/retest ci/centos/mini-e2e/k8s-1.21

Aug  6 11:08:01.318: INFO: Running '/usr/bin/kubectl --server=https://192.168.39.251:8443 --kubeconfig=/root/.kube/config --namespace=cephcsi-e2e-e8a501ee create -f -'
Aug  6 11:08:13.504: INFO: rc: 1
Aug  6 11:08:15.508: INFO: Running '/usr/bin/kubectl --server=https://192.168.39.251:8443 --kubeconfig=/root/.kube/config --namespace=cephcsi-e2e-e8a501ee create -f -'
Aug  6 11:08:16.257: INFO: rc: 1
Aug  6 11:08:16.257: INFO: will run kubectl (create) again (14 seconds elapsed)
Aug  6 11:08:16.257: FAIL: failed to create vault statefulset failed to run kubectl: error running /usr/bin/kubectl --server=https://192.168.39.251:8443 --kubeconfig=/root/.kube/config --namespace=cephcsi-e2e-e8a501ee create -f -:
Command stdout:

stderr:
Error from server (AlreadyExists): error when creating "STDIN": serviceaccounts "rbd-csi-vault-token-review" already exists
Error from server (AlreadyExists): error when creating "STDIN": clusterroles.rbac.authorization.k8s.io "rbd-csi-vault-token-review" already exists
Error from server (AlreadyExists): error when creating "STDIN": clusterrolebindings.rbac.authorization.k8s.io "rbd-csi-vault-token-review" already exists

error:
exit status 1

is expected to be fixed with #2329 (which isn't backported)

@mergify mergify bot merged commit 459f6ec into release-v3.4 Aug 6, 2021
@mergify mergify bot deleted the mergify/bp/release-v3.4/pr-2351 branch August 6, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants