cleanup: error is not nil but returns nil #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
approved these changes
Jun 25, 2021
| @@ -378,7 +378,7 @@ func checkDataPersist(pvcPath, appPath string, f *framework.Framework) error { | |||
|
|
|||
| _, stdErr, err := execCommandInPod(f, fmt.Sprintf("echo %s > %s", data, filePath), app.Namespace, &opt) | |||
| if err != nil { | |||
| return nil | |||
| return fmt.Errorf("failed to exec command in pod: %w", err) | |||
There was a problem hiding this comment.
When you notice duplication like the above writing of data to a file, you can always create a helper function that returns a single error instead of stdErr and err. Not required for this PR, but small things like that are good cleanups too!
There was a problem hiding this comment.
Yes sure. I will do it another PR.
Madhu-1
approved these changes
Jun 25, 2021
|
@Mergifyio rebase |
|
Command
|
In few places the error is not nil still it returns nil. Updates: ceph#1586 Signed-off-by: Yati Padia <ypadia@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In few places, the error is not nil still it
returns nil.
Updates: #1586
Signed-off-by: Yati Padia ypadia@redhat.com