Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix helm chart pushing #2007

Merged
merged 2 commits into from
Apr 22, 2021
Merged

build: Fix helm chart pushing #2007

merged 2 commits into from
Apr 22, 2021

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Apr 22, 2021

Removed helm init commands as helm v3.x does not have the init command see helm/helm#6996 and also install the helm from the version specified in the build.env

resolves #2006

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

Madhu-1 added 2 commits April 22, 2021 11:13
Install the helm package based on the version
specified in the build.env

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
from helm v3.x version there is no helm init
command. Removing the helm init which was causing
helm chart pushing issue in release and devel
branch.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 Madhu-1 added component/build Issues and PRs related to compiling Ceph-CSI ci/skip/e2e skip running e2e CI jobs backport-to-release-v3.3 labels Apr 22, 2021
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Apr 22, 2021

skipping e2e as the change is in deploy.sh which will get executed when the PR is merged.

@Madhu-1 Madhu-1 requested review from humblec and nixpanic April 22, 2021 06:06
deploy.sh Show resolved Hide resolved
@mergify mergify bot merged commit 6508726 into ceph:devel Apr 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2021

This pull request has been merged with the
unsupported configuration option bot_account.

This option will be ignored starting May 1st, 2021, and removed
on June 1st, 2021.

This option can be replaced by update_bot_account, merge_bot_account or both
depending on your use-case (https://docs.mergify.io/actions/merge/).

@humblec
Copy link
Collaborator

humblec commented Apr 22, 2021

@Madhu-1 good to backport this to 3.3 branch too.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Apr 22, 2021

@Madhu-1 good to backport this to 3.3 branch too.

Doing it

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented May 3, 2021

@Mergifyio backport release-v3.2

@mergify
Copy link
Contributor

mergify bot commented May 3, 2021

Command backport release-v3.2: success

Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/e2e skip running e2e CI jobs component/build Issues and PRs related to compiling Ceph-CSI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to push helm charts from Travis CI
3 participants