Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "master" branch to "devel" #1890

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Feb 25, 2021

This PR renames all occasions of "master" to "devel" where the reference is relevant to Ceph-CSI.

Once this PR is merged, an admin of the GitHub project will need to rename the branch before next PRs can get merged. The GitHub documentation describes that all the existing PRs for the "master" branch will automatically be updated to the new "devel" branch.

A 2nd PR is filed to update the "ci/centos" branch (PR #1891), so that the CI jobs use the new branch name.

See-also: https://docs.github.com/en/github/administering-a-repository/renaming-a-branch
Updates: #1193


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
@nixpanic nixpanic added Repo activity Process/activites on ceph-csi repo component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/docs Issues and PRs related to documentation component/build Issues and PRs related to compiling Ceph-CSI labels Feb 25, 2021
@nixpanic nixpanic requested review from humblec and Madhu-1 February 25, 2021 08:29
@humblec
Copy link
Collaborator

humblec commented Feb 25, 2021

Thanks @nixpanic .. commitlint error out in this version of the patch.

@humblec
Copy link
Collaborator

humblec commented Feb 25, 2021

One other suggestion I have here is, imo, its good to document about this change for history with details on why we do that..etc. What do you think ?

@nixpanic
Copy link
Member Author

Thanks @nixpanic .. commitlint error out in this version of the patch.

commitlint failed because it tries to use the devel branch now, and that does not exist. Please review the commits manually.

@nixpanic
Copy link
Member Author

One other suggestion I have here is, imo, its good to document about this change for history with details on why we do that..etc. What do you think ?

That can be expanded in #1193 if you think that is not sufficient. I do not think we need to document it in the repository itself?

@nixpanic nixpanic linked an issue Feb 25, 2021 that may be closed by this pull request
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Mar 1, 2021

Merging the PR manually

@Madhu-1 Madhu-1 merged commit 92190de into ceph:master Mar 1, 2021
@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 3, 2021

@Mergifyio backport release-v3.2

@mergify
Copy link
Contributor

mergify bot commented May 3, 2021

Command backport release-v3.2: failure

No backport have been created

  • Backport to branch release-v3.2 failed
    Git reported the following error:
fatal: couldn't find remote ref master

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 3, 2021

@nixpanic can you please backport this to release-3.2 branch? as a change from this is missing in release-v3.2 branch CI is failing at #2041

@humblec
Copy link
Collaborator

humblec commented May 3, 2021

@nixpanic can you please backport this to release-3.2 branch? as a change from this is missing in release-v3.2 branch CI is failing at #2041

May be to all previous releases ?

@nixpanic
Copy link
Member Author

nixpanic commented May 3, 2021

@nixpanic can you please backport this to release-3.2 branch? as a change from this is missing in release-v3.2 branch CI is failing at #2041

Sure, will do!

@nixpanic
Copy link
Member Author

nixpanic commented May 3, 2021

@nixpanic can you please backport this to release-3.2 branch? as a change from this is missing in release-v3.2 branch CI is failing at #2041

May be to all previous releases ?

What other older releases are still maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Issues and PRs related to compiling Ceph-CSI component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/docs Issues and PRs related to documentation Repo activity Process/activites on ceph-csi repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the "master" branch to "devel" or similar
3 participants