Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide capacity of block-mode RBD volumes #1831

Merged
merged 3 commits into from
May 25, 2021
Merged

Provide capacity of block-mode RBD volumes #1831

merged 3 commits into from
May 25, 2021

Commits on May 25, 2021

  1. cephfs: move NodeGetVolumeStats() to CephFS NodeServer 

    The CephFS NodeServer should handle the CephFS specific requests. This
is not something that the NodeServer for RBD should handle.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
    @nixpanic
    nixpanic authored and mergify-bot committed May 25, 2021
    Configuration menu
    Copy the full SHA
    50581f1 View commit details
    Browse the repository at this point in the history

  2. rbd: add support for block-devices in NodeGetVolumeStats() 

    The NodeGetVolumeStats procedure can now be used to fetch the capacity
of the RBD block-device. By default this is a thin-provisioned device,
which means that the capacity is not reserved in the Ceph cluster. This
makes it possible to over-provision the cluster.

In order to detect the amount of storage used by the RBD block-device
(when thin-provisioned), it is required to connect to the Ceph cluster.
Unfortunately, the NodeGetVolumeStats CSI procedure does not provide
enough parameters to connect to the Ceph cluster and fetch more details
about the RBD image.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
    @nixpanic
    nixpanic authored and mergify-bot committed May 25, 2021
    Configuration menu
    Copy the full SHA
    6bdc21a View commit details
    Browse the repository at this point in the history

  3. e2e: fetch volume metrics from Kubelet 

    Test if metrics are available at all. The actual values are a little
difficult to validate.

BlockMode volumes support metrics since Kubernetes 1.22.

See-also: kubernetes/kubernetes#97972
Signed-off-by: Niels de Vos <ndevos@redhat.com>
    @nixpanic
    nixpanic authored and mergify-bot committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d3f4450 View commit details
    Browse the repository at this point in the history