Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: fix namespace json parser for xbdDeviceInfo (bp #1821) #1822

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 5, 2021

This is an automated backport of pull request #1821 done by Mergify

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jan 5, 2021

/test all

@nixpanic
Copy link
Member

nixpanic commented Jan 5, 2021

Not sure what's wrong, but most failures seem to be in the form of

failed to fetch monitor list using clusterID (181d8784-cd9c-42c1-a196-25b364d42f94): missing configuration for cluster ID (181d8784-cd9c-42c1-a196-25b364d42f94)

This is not something that seems to be introduced by this PR 🤔

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jan 6, 2021

looks like same issue as #1791. should be fixed once we backport #1794 to release-3.2 branch

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jan 6, 2021

@Mergifyio rebase

rbd device list --format=json returns namespace as a namespace not radosNamespace

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit fdec9f6)
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 1f17d25)
@mergify
Copy link
Contributor Author

mergify bot commented Jan 6, 2021

Command rebase: success

Branch has been successfully rebased

@Madhu-1 Madhu-1 force-pushed the mergify/bp/release-v3.2/pr-1821 branch from 851314e to d2f6ce5 Compare January 6, 2021 08:06
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jan 6, 2021

/test ci/centos/mini-e2e/k8s-1.19

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jan 6, 2021

/test ci/centos/mini-e2e/k8s-1.19

Rook deployment failed, restarting the test

@mergify mergify bot merged commit 96245a3 into release-v3.2 Jan 6, 2021
@mergify mergify bot deleted the mergify/bp/release-v3.2/pr-1821 branch January 6, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants