-
Notifications
You must be signed in to change notification settings - Fork 553
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
helm: CSIDriver add labels and seLinuxMount disabling method
Signed-off-by: Ruslan Khizhnyak <rkhizhnyak@ptsecurity.com>
- Loading branch information
1 parent
cd18490
commit d56c9ab
Showing
4 changed files
with
35 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d56c9ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work? Isnt the d56c9ab#diff-68721d823f92f715b462328b58c31d49c0723f0e6f83ae76ab3e0e20e1df9717R15 and d56c9ab#diff-3879d9633ecdec5db38e5cfe6ae2db459f9c0763bb27a2e2128173e6720061e9R15 value under d56c9ab#diff-f1b11c5f81f992e01a7019d45b7fc930ca4f6268b1e7ff018ee5a327950b4e2dR60 .Values.CSIDriver.seLinuxMount ?
Also is this not also related to 4235178 and .Values.selinuxMount?
related #4437, #4512, #4358
d56c9ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
.Values.selinuxMount
is enabled, it makes sense that the CSIDriver should also have itsseLinuxMount
option enabled. The CSIDriver object is used by Kubelet and applies certain SElinux settings to mounted volumes.But yes, I do not think
.Values.CSIDriver.seLinuxMount
is used anywhere 🤔 Maybe @Rakshith-R remembers/knows what the intention was.d56c9ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Values.selinuxMount
is for mounting the host /etc/selinux inside pods to support selinux-enabled filesystems
..Values.csiDriver.selinuxMount
should be used to set csidriver parameter.#4519 raised by @iPraveenParihar fixes this issue.
He has explained it in the pr too.
Thanks for pointing it out @Velociraptor85 !