cephadm-adopt: Fixes binding network for alertmanager #7576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alertmanager was bind to default * network instead of grafana_server_addr as it was before. Now on if grafana_server_addr is defined, it will be bind to that network. Signed-off-by: Teoman ONAY <tonay@ibm.com>
|
jenkins test centos-container-cephadm_adopt |
|
jenkins test centos-non_container-update |
|
jenkins test centos-non_container-all_daemons |
guits
approved these changes
Jul 14, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
guits
approved these changes
Jul 30, 2024
This was referenced Aug 5, 2024
asm0deuz
added a commit
to asm0deuz/ceph-ansible
that referenced
this pull request
Oct 2, 2024
Regression from ceph#7576. Alertmanager placement count was missing after migration to ceph_orch_apply module Signed-off-by: Teoman ONAY <tonay@ibm.com>
asm0deuz
added a commit
to asm0deuz/ceph-ansible
that referenced
this pull request
Oct 11, 2024
Regression from ceph#7576. Alertmanager placement count was missing after migration to ceph_orch_apply module Signed-off-by: Teoman ONAY <tonay@ibm.com>
asm0deuz
added a commit
to asm0deuz/ceph-ansible
that referenced
this pull request
Oct 12, 2024
Regression from ceph#7576. Alertmanager placement count was missing after migration to ceph_orch_apply module Signed-off-by: Teoman ONAY <tonay@ibm.com>
asm0deuz
added a commit
that referenced
this pull request
Oct 14, 2024
Regression from #7576. Alertmanager placement count was missing after migration to ceph_orch_apply module Signed-off-by: Teoman ONAY <tonay@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alertmanager was bind to default * network instead of grafana_server_addr as it was before. Now on if grafana_server_addr is defined, it will be bind to that network.