Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: code quality issues #416

Closed
wants to merge 1 commit into from
Closed

Fix: code quality issues #416

wants to merge 1 commit into from

Conversation

withshubh
Copy link

Description

Hi 👋
I ran the DeepSource static analyzer on the forked copy of this repo and found some interesting code quality issues. I have fixed a few of them in this PR.

Summary of changes

  • Removed unused code
  • Removed redundant return statement
  • added .deepsource.toml

- Removed unused code

- Removed redundant return statement
@FZambia
Copy link
Member

FZambia commented Jan 20, 2021

@withshubh hello, thanks! But seems that I just fixed this in #417 while adding golangci-lint

@FZambia FZambia closed this Jan 20, 2021
@withshubh
Copy link
Author

withshubh commented Jan 20, 2021

There are more issues in this repo which you might want to have a look. @FZambia

@FZambia
Copy link
Member

FZambia commented Jan 20, 2021

@withshubh thanks, addressing file perm warning in #418 , other issues look minor enough. Thanks for pr - I'll take a closer look at DeepSource in the future.

@withshubh
Copy link
Author

withshubh commented Jan 20, 2021

Thanks @FZambia 😊 If you want then I can create an issue for integration of DeepSource with the steps.

@FZambia
Copy link
Member

FZambia commented Jan 20, 2021

At this moment I prefer to not integrate so such an issue will be pretty stale and probably closed. Integration is simple enough – if I decide this is a right move we'll do this.

BTW, does DeepSource.io support one-time repo analysis without full integration?

@withshubh
Copy link
Author

At this moment I prefer to not integrate so such an issue will be pretty stale and probably closed. Integration is simple enough – if I decide this is a right move we'll do this.

BTW, does DeepSource.io support one-time repo analysis without full integration?

As of now there is no option to run one time analysis but we're working on CLI that will help you do so.

@withshubh
Copy link
Author

Hey @FZambia 👋 I hope you're doing good.

Just wanted to share that DeepSource released CLI last month. I would really appreciate it if you could try it out and share your feedback with us. : )

@FZambia
Copy link
Member

FZambia commented Apr 15, 2021

@withshubh hello, great to hear! I don't want to create account on deepsource to test this feature out.

@withshubh
Copy link
Author

Okay @FZambia we won't be able to run analysis without an account :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants