-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: code quality issues #416
Conversation
- Removed unused code - Removed redundant return statement
@withshubh hello, thanks! But seems that I just fixed this in #417 while adding |
There are more issues in this repo which you might want to have a look. @FZambia |
@withshubh thanks, addressing file perm warning in #418 , other issues look minor enough. Thanks for pr - I'll take a closer look at DeepSource in the future. |
Thanks @FZambia 😊 If you want then I can create an issue for integration of DeepSource with the steps. |
At this moment I prefer to not integrate so such an issue will be pretty stale and probably closed. Integration is simple enough – if I decide this is a right move we'll do this. BTW, does DeepSource.io support one-time repo analysis without full integration? |
As of now there is no option to run one time analysis but we're working on CLI that will help you do so. |
@withshubh hello, great to hear! I don't want to create account on deepsource to test this feature out. |
Okay @FZambia we won't be able to run analysis without an account :( |
Description
Hi 👋
I ran the DeepSource static analyzer on the forked copy of this repo and found some interesting code quality issues. I have fixed a few of them in this PR.
Summary of changes