Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Proxy headers more options or proxy all #334

Closed
telemmaite opened this issue Jan 6, 2020 · 4 comments · Fixed by #335
Closed

[feature] Proxy headers more options or proxy all #334

telemmaite opened this issue Jan 6, 2020 · 4 comments · Fixed by #335

Comments

@telemmaite
Copy link

telemmaite commented Jan 6, 2020

Is your feature request related to a problem? Please describe.
We are using distributed tracing for example https://opentracing.io/, https://zipkin.io/ (https://zipkin.io/pages/architecture.html, https://github.com/openzipkin/b3-propagation)

We have the option to trace request from from frontend > through backend > back to frontend.
This means a few trace headers are added, as quoted:

For example, when an operation is being traced and it needs to make an outgoing http request, a few headers are added to propagate IDs. Headers are not used to send details such as the operation name.


Describe the solution you'd like

  1. Would it be possible to allow proxying all headers, not just this limited list.
    var proxyHeaders = []string{
  2. Alternatively allow configuration of list of extra headers, like X-B3-TraceId, X-B3-SpanId, X-B3-Sampled etc...

Describe alternatives you've considered
Missing part of our tracing log for all proxied requests from centrifugo, if the headers are not passed our backend will assume it is the first entry point and we will add the headers on the trip back.

@FZambia
Copy link
Member

FZambia commented Jan 7, 2020

@telemmaite yeah, this is reasonable to have. We should not proxy all headers as those can contain a lot of headers that do not have much sense like Connection: Upgrade, Pragma: no-cache etc, but having a white list of extra headers is helpful.

Please look at #335 - is it ok?

@telemmaite
Copy link
Author

@FZambia looks great and thank you very much for your effort on this project!

@FZambia
Copy link
Member

FZambia commented Jan 9, 2020

@telemmaite hi, released new version with new proxy features - v2.3.1

@telemmaite
Copy link
Author

@FZambia thank you! Already using the data object with the proxy authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants