Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ctor-1233]: Test(Plugin(network::hp::procurve::snmp)): mode=spanning-tree,list-spanning-trees #5345

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

[Ctor-1233]: Test(Plugin(network::hp::procurve::snmp)): mode=spanning-tree,list-spanning-trees #5345

wants to merge 9 commits into from

Conversation

sfarouq-ext
Copy link
Contributor

@sfarouq-ext sfarouq-ext commented Dec 11, 2024 •
edited by lucie-dubrunfaut
Loading

Centreon team

Description

Discover and monitor spanning tree on hp procurve switches.
Community contribution : #5198

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

With automated added inside.

Checklist

  • I have rebased my development branch on the base branch (develop).
  • I have implemented automated tests related to my commits.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@sfarouq-ext sfarouq-ext requested review from a team as code owners December 11, 2024 16:20
@sfarouq-ext sfarouq-ext force-pushed the CTOR-1233-plugin-network-hp-procurve-snmp-add-spanning-tree-mode-and-discovery branch from c717e3e to 17c7ea1 Compare December 11, 2024 16:43
@lucie-dubrunfaut lucie-dubrunfaut mentioned this pull request Dec 16, 2024
Closed
@sfarouq-ext sfarouq-ext force-pushed the CTOR-1233-plugin-network-hp-procurve-snmp-add-spanning-tree-mode-and-discovery branch from 24d69a9 to f17b5c6 Compare December 18, 2024 10:33
@lucie-dubrunfaut @omercier
Apply suggestions from code review
6575d27 
Co-authored-by: omercier <32134301+omercier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucie-dubrunfaut lucie-dubrunfaut lucie-dubrunfaut left review comments

@Evan-Adam Evan-Adam Evan-Adam approved these changes

@omercier omercier omercier approved these changes

@bouda1 bouda1 Awaiting requested review from bouda1 bouda1 is a code owner automatically assigned from centreon/owners-robot-e2e

@jean-christophe81 jean-christophe81 Awaiting requested review from jean-christophe81 jean-christophe81 is a code owner automatically assigned from centreon/owners-robot-e2e

@sdepassio sdepassio Awaiting requested review from sdepassio

Assignees
No one assigned
Labels
skip-workflow-plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfarouq-ext @omercier @lucie-dubrunfaut @Evan-Adam