Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTOR 1176: Plugin(os::freebsd::snmp) - Mode(storage): add default ZFS support + tests #5296

Merged

Conversation

itoussies
Copy link
Contributor

@itoussies itoussies commented Nov 21, 2024

Description

The latest version of pfSense (2.7.2) is based on freeBSD 14 and has ZFS as the default file system. This PR enhance the storage mode to support ZFS file system monitoring by default. Tests are also added.

@itoussies itoussies requested review from a team as code owners November 21, 2024 15:41
@itoussies itoussies requested a review from a team as a code owner November 25, 2024 09:52
@itoussies itoussies requested review from ddes and kduret November 25, 2024 09:52
@lucie-dubrunfaut lucie-dubrunfaut changed the title CTOR 1176: Enhance FreeBSD storage - Add default ZFS support + tests CTOR 1176: Plugin(os::freebsd::snmp) - Mode(storage): add default ZFS support + tests Nov 28, 2024
tests/os/freebsd/snmp/cpu-detailed.robot Outdated Show resolved Hide resolved
tests/os/freebsd/snmp/inodes.robot Outdated Show resolved Hide resolved
tests/os/freebsd/snmp/list-diskspath.robot Outdated Show resolved Hide resolved
tests/os/freebsd/snmp/cpu-detailed.robot Outdated Show resolved Hide resolved
Evan-Adam
Evan-Adam previously approved these changes Dec 16, 2024
@omercier
Copy link
Contributor

Other suggestions (could not do them in gh suggestions) :

  • Freebsd --> FreeBSD in plugin.pm
  • Some modes ('cpu', 'load, 'swap', 'memory') needs 'bsnmp-ucd'. --> Some modes (C<cpu>, C<load>, C<swap>, C<memory>) need C<bsnmp-ucd>.

@omercier omercier merged commit 0ddcaf9 into develop Jan 10, 2025
27 checks passed
@omercier omercier deleted the MON-145003-enhance-free-bsd-storage-add-default-zfs-support branch January 10, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants