Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(plugin): added 64 bits counters in snmp_standard::memory #5210

Merged
merged 1 commit into from
Oct 1, 2024
Merged

enh(plugin): added 64 bits counters in snmp_standard::memory #5210

merged 1 commit into from
Oct 1, 2024

Conversation

omercier
Copy link
Contributor

@omercier omercier commented Sep 27, 2024 •
edited
Loading

Description

Added an option to switch to 64bits counters for memory. Default is to stick with 32 bits (this mode is used by several plugins, so it would be unsafe to change the default behaviour).

REFS: CTOR-542

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Robot tests have been added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@omercier omercier marked this pull request as ready for review September 27, 2024 16:58
@omercier omercier requested review from a team as code owners September 27, 2024 16:58
sdepassio
sdepassio previously approved these changes Sep 30, 2024
View reviewed changes
@omercier
enh(plugin): handle 64 bits counters in snmp_standard::memory
f886222 
Merged commits:
- fix(tests): fixed spellchecks and Safe missing dependency on Alma9
- fix(stopwords): added net-snmp
- Apply suggestions from code review
- Update src/snmp_standard/mode/memory.pm
- enh(workflow): consider building plugins when the default dependencies are changed
- enh(code): use is_snmpv1() method as suggested by @garnier-quentin ;)

Co-authored-by: sdepassio <114986849+sdepassio@users.noreply.github.com>
Co-authored-by: Evan-Adam <152897682+Evan-Adam@users.noreply.github.com>

REFS: CTOR-542
@omercier omercier force-pushed the CTOR-542-Plugin-os-linux-snmp-Mode-memory-Issue-in-case-very-big-memory-size branch from 763a8a7 to f886222 Compare October 1, 2024 12:22
@omercier omercier merged commit 3b4ef12 into develop Oct 1, 2024
23 checks passed
@omercier omercier deleted the CTOR-542-Plugin-os-linux-snmp-Mode-memory-Issue-in-case-very-big-memory-size branch October 1, 2024 15:50
sfarouq-ext pushed a commit that referenced this pull request Oct 3, 2024
@omercier @sfarouq-ext
enh(plugin): added 64 bits counters in snmp_standard::memory (#5210)
7f4b473 
- fix(tests): fixed spellchecks and Safe missing dependency on Alma9
- fix(stopwords): added net-snmp
- Apply suggestions from code review
- Update src/snmp_standard/mode/memory.pm
- enh(workflow): consider building plugins when the default dependencies are changed
- enh(code): use is_snmpv1() method as suggested by @garnier-quentin ;)

Co-authored-by: sdepassio <114986849+sdepassio@users.noreply.github.com>
Co-authored-by: Evan-Adam <152897682+Evan-Adam@users.noreply.github.com>

REFS: CTOR-542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garnier-quentin garnier-quentin garnier-quentin left review comments

@Evan-Adam Evan-Adam Evan-Adam approved these changes

@sdepassio sdepassio sdepassio approved these changes

@mushroomempires mushroomempires mushroomempires approved these changes

@kduret kduret Awaiting requested review from kduret kduret is a code owner automatically assigned from centreon/owners-pipelines

@tuntoja tuntoja Awaiting requested review from tuntoja tuntoja is a code owner automatically assigned from centreon/owners-pipelines

@jean-christophe81 jean-christophe81 Awaiting requested review from jean-christophe81 jean-christophe81 is a code owner automatically assigned from centreon/owners-robot-e2e

@lucie-dubrunfaut lucie-dubrunfaut Awaiting requested review from lucie-dubrunfaut lucie-dubrunfaut is a code owner automatically assigned from centreon/owners-robot-e2e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omercier @garnier-quentin @mushroomempires @sdepassio @Evan-Adam