Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctor 396 pack centreon plugin cloud vmware velocloud restapi mode list edges don t retrieve informations and get http code 400 #5133

Conversation

omercier
Copy link
Contributor

@omercier omercier commented Aug 5, 2024

Description

REFS: CTOR-396

Users reported that the edge-related modes were failing because of a missing empty body in POST queries. Thanks @alexvea and @DalfoCentreon for the fix!

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

See Robot tests.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.

@omercier omercier marked this pull request as ready for review August 5, 2024 10:03
@omercier omercier requested review from a team as code owners August 5, 2024 10:03
Evan-Adam
Evan-Adam previously approved these changes Aug 6, 2024
sdepassio
sdepassio previously approved these changes Aug 7, 2024
@Evan-Adam Evan-Adam dismissed stale reviews from sdepassio and themself via eb4f8e5 August 7, 2024 14:22
@Evan-Adam Evan-Adam force-pushed the CTOR-396-Pack-centreon-plugin-Cloud-Vmware-Velocloud-Restapi-Mode-list-edges-Don-t-retrieve-informations-and-get-http-code-400 branch from 7ce7007 to eb4f8e5 Compare August 7, 2024 14:22
@Evan-Adam Evan-Adam merged commit 792cefd into develop Aug 7, 2024
17 checks passed
@Evan-Adam Evan-Adam deleted the CTOR-396-Pack-centreon-plugin-Cloud-Vmware-Velocloud-Restapi-Mode-list-edges-Don-t-retrieve-informations-and-get-http-code-400 branch August 7, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants