Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(monitoring): issue with command line for meta service #9634

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

adr-mo
Copy link
Contributor

@adr-mo adr-mo commented Mar 30, 2021

Description

This PR intends to fix an issue with Meta Services details on legacy pages. The hide password command was trying to get the Meta Service configuration though findService method which uses centreon.service table.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 19.10.x
  • 20.04.x
  • 20.10.x
  • 21.04.x (master)

How this pull request can be tested ?

  • Create a Meta Service
  • Generate, push and reload configuration
  • Go to Monitoring -> Status details -> Services - Meta detail
  • CommandLine should be displayed

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@adr-mo adr-mo requested review from a team, loiclau, jeremyjaouen and kduret March 30, 2021 22:10
kduret
kduret previously approved these changes Mar 31, 2021
Nohzoh
Nohzoh previously approved these changes Mar 31, 2021
@adr-mo adr-mo dismissed stale reviews from Nohzoh and kduret via b248d5e March 31, 2021 07:09
Co-authored-by: Kevin Duret <kduret@centreon.com>
@adr-mo adr-mo requested a review from Nohzoh March 31, 2021 07:41
@adr-mo adr-mo merged commit f6a12a7 into master Mar 31, 2021
@adr-mo adr-mo deleted the MON-6914-hide-password-meta-service branch March 31, 2021 08:19
adr-mo added a commit that referenced this pull request Mar 31, 2021
* fix(monitoring): issue with command line for meta service

* Update src/Centreon/Domain/Monitoring/MonitoringService.php

Co-authored-by: Kevin Duret <kduret@centreon.com>

Co-authored-by: Kevin Duret <kduret@centreon.com>
adr-mo added a commit that referenced this pull request Mar 31, 2021
* fix(monitoring): issue with command line for meta service

* Update src/Centreon/Domain/Monitoring/MonitoringService.php

Co-authored-by: Kevin Duret <kduret@centreon.com>

Co-authored-by: Kevin Duret <kduret@centreon.com>
adr-mo added a commit that referenced this pull request Mar 31, 2021
* fix(monitoring): issue with command line for meta service

* Update src/Centreon/Domain/Monitoring/MonitoringService.php

Co-authored-by: Kevin Duret <kduret@centreon.com>

Co-authored-by: Kevin Duret <kduret@centreon.com>
adr-mo added a commit that referenced this pull request Mar 31, 2021
* fix(monitoring): issue with command line for meta service

* Update src/Centreon/Domain/Monitoring/MonitoringService.php

Co-authored-by: Kevin Duret <kduret@centreon.com>

Co-authored-by: Kevin Duret <kduret@centreon.com>
kduret added a commit that referenced this pull request Apr 1, 2021
* fix(monitoring): issue with command line for meta service

* Update src/Centreon/Domain/Monitoring/MonitoringService.php

Co-authored-by: Kevin Duret <kduret@centreon.com>

Co-authored-by: Kevin Duret <kduret@centreon.com>
kduret added a commit that referenced this pull request Apr 1, 2021
* fix(monitoring): issue with command line for meta service

* Update src/Centreon/Domain/Monitoring/MonitoringService.php

Co-authored-by: Kevin Duret <kduret@centreon.com>

Co-authored-by: Kevin Duret <kduret@centreon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants