This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(secu): sanitize host dashboard #9406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
suggested changes
Jan 18, 2021
Comment on lines
70
to
71
| if ( | ||
| $period_choice == 'custom' && |
There was a problem hiding this comment.
Suggested change
| if ( | |
| $period_choice == 'custom' && | |
| if ($period_choice == 'custom' && |
Comment on lines
91
to
93
| list($start_date, $end_date) = $interval; | ||
|
|
||
| return(array($start_date, $end_date)); |
There was a problem hiding this comment.
JAC
why not return $interval ?
if interval contains only $start_date and $end_date
There was a problem hiding this comment.
Did not really thought it through 👍
I'll keep it this way for now
Comment on lines
42
to
44
| $start_date = ''; | ||
| $end_date = ''; | ||
| $period_choice = ''; |
There was a problem hiding this comment.
could you convert these variables to camelCase
|
@sc979 Sure 👍 |
|
✔️ Done :) |
sc979
approved these changes
Jan 19, 2021
kduret
approved these changes
Jan 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of https://github.com/centreon/centreon/pull/9372
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist