Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(security): use user id instead of session id in session page #8876

Merged
merged 5 commits into from
Jul 29, 2020
Merged

fix(security): use user id instead of session id in session page #8876

merged 5 commits into from
Jul 29, 2020

Conversation

jeremyjaouen
Copy link
Contributor

@jeremyjaouen jeremyjaouen commented Jul 27, 2020 •
edited
Loading

Description

This PR fix the Logout User URL on Sessions page.

Fixes MON-4542

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 19.04.x
  • 19.10.x
  • 20.04.x
  • 20.10.x (master)

Checklist

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@jeremyjaouen jeremyjaouen requested a review from sc979 July 28, 2020 07:34
@sc979 sc979 changed the title fix(sessions): use user id to logout user fix(security): use user id instead of session id in session page Jul 28, 2020
@jeremyjaouen jeremyjaouen requested a review from sc979 July 28, 2020 08:40
jeremyjaouen and others added 2 commits July 28, 2020 10:48
@jeremyjaouen @sc979
remove commentary
3f88d3f 
Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com>
@jeremyjaouen @sc979
adapt commentary
76f8aeb 
Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com>
@jeremyjaouen jeremyjaouen merged commit a589cd1 into master Jul 29, 2020
@jeremyjaouen jeremyjaouen deleted the MON-4542 branch July 29, 2020 20:22
jeremyjaouen added a commit that referenced this pull request Jul 30, 2020
@jeremyjaouen
fix(security): use user id instead of session id in session page (#8876)
afb5554
jeremyjaouen added a commit that referenced this pull request Jul 30, 2020
@jeremyjaouen
fix(security): use user id instead of session id in session page (#8876)
da19665
jeremyjaouen added a commit that referenced this pull request Jul 30, 2020
@jeremyjaouen
fix(security): use user id instead of session id in session page (#8876)
236a8bc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sc979 sc979 sc979 approved these changes

@lpinsivy lpinsivy lpinsivy approved these changes

@loiclau loiclau Awaiting requested review from loiclau

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyjaouen @lpinsivy @sc979