Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(install): wrong value used for checkboxes refresh #8457

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

adr-mo
Copy link
Contributor

@adr-mo adr-mo commented Mar 24, 2020

Description

When the install was done of the modules/widgets in the step 7 of a fresh installation, the checkboxes were not correctly refreshed

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

  • Prepare a fresh install of Centreon (with rpm installed modules like autodisco, bam, map, mbi)
  • On step 7 of fresh installation when the selected modules are installed (click on the button)
    • Dependencies of the modules should be automatically installed
    • The checkboxes are turned into a green tick and disabled.

Checklist

Requirements

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

sc979
sc979 previously approved these changes Mar 24, 2020
Copy link
Contributor

@jdelpierre jdelpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't the key "name"?

kduret
kduret previously approved these changes Mar 24, 2020
@adr-mo
Copy link
Contributor Author

adr-mo commented Mar 24, 2020

Because it is not implement this way in the backend. I'm not totaly sure of the impacts so I dit not change the structure of the result cc @jdelpierre

jdelpierre
jdelpierre previously approved these changes Mar 24, 2020
@adr-mo adr-mo added area/install pr/internal-rd PR made by the Centreon R&D Team labels Mar 24, 2020
@adr-mo adr-mo dismissed stale reviews from jdelpierre, kduret, and sc979 via 2d1d186 March 25, 2020 08:34
@adr-mo adr-mo force-pushed the MON-4782-refresh-issue branch from be21527 to 2d1d186 Compare March 25, 2020 08:34
@adr-mo adr-mo merged commit 5707e3a into master Mar 25, 2020
@adr-mo adr-mo deleted the MON-4782-refresh-issue branch March 25, 2020 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/install pr/internal-rd PR made by the Centreon R&D Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants