Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(api): Combining type & search bar doesn't work #8427

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

vhr
Copy link
Contributor

@vhr vhr commented Mar 19, 2020

Description

improve the check for service criteria in Resource list API, if contains host criteria too will skip the check

Fixes MON-5026

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@vhr vhr requested review from kduret and victorvassilev March 19, 2020 11:33
@vhr vhr force-pushed the MON-5026-improve-service-check branch from 8702b45 to 14f4f90 Compare March 19, 2020 11:36
@vhr vhr merged commit 6c82eef into master Mar 19, 2020
@vhr vhr deleted the MON-5026-improve-service-check branch March 19, 2020 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants