This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(centreonACL): return all services linked to a servicegroup #8406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adr-mo
added
pr/internal-rd
sc979
reviewed
Mar 11, 2020
sc979
reviewed
Mar 11, 2020
sc979
reviewed
Mar 11, 2020
sc979
added
area/acl
area/monitoring
kind/bug
and removed
status/in-backlog
* Sanitize the servicegroup id * add missing code line to get only activated ressources
|
Feedbacks taken into account ! Thanks @sc979 for feedback and help 👍 |
sc979
previously approved these changes
Mar 11, 2020
kduret
previously approved these changes
Mar 11, 2020
Co-Authored-By: Kevin Duret <kduret@centreon.com>
sc979
approved these changes
Mar 12, 2020
kduret
approved these changes
Mar 12, 2020
callapa
approved these changes
Mar 12, 2020
adr-mo
added a commit
that referenced
this pull request
Mar 12, 2020
* fix(centreonACL): return all services linked to a servicegroup * enh(centreonACL): add some code documentation * fix(centreonACL): take review feedbacks into account * Sanitize the servicegroup id * add missing code line to get only activated ressources * fix(centreonACL): variable enough checked. * take kduret feedback into account Co-Authored-By: Kevin Duret <kduret@centreon.com> Co-authored-by: Kevin Duret <kduret@centreon.com>
adr-mo
added a commit
that referenced
this pull request
Mar 12, 2020
* fix(centreonACL): return all services linked to a servicegroup * enh(centreonACL): add some code documentation * fix(centreonACL): take review feedbacks into account * Sanitize the servicegroup id * add missing code line to get only activated ressources * fix(centreonACL): variable enough checked. * take kduret feedback into account Co-Authored-By: Kevin Duret <kduret@centreon.com> Co-authored-by: Kevin Duret <kduret@centreon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue here was that when linking service templates to define a servicegroup, those where not "resolved" which lead to the non-consistent listing in the Reporting -> Dashboard -> Service Groups feature.
Using the centreon_storage database to get the information, where the services_servicegroups table provides "resolved" dependencies of possible components of the servicegroup which can be:
Type of change
Target serie
How this pull request can be tested ?
The listing should display all the services linked to the servicegroup.
IMPORTANT
The test should also be done using an user with ACL on ressources.
Checklist
Community contributors & Centreon team
Centreon team only