Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(core): source installation script fixes #8341

Merged
merged 10 commits into from
Feb 19, 2020
Merged

fix(core): source installation script fixes #8341

merged 10 commits into from
Feb 19, 2020

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Feb 14, 2020 •
edited
Loading

Description

1- Correct source installation script (eg: ubuntu and debian) :

  • randomize the APP_SECRET in .env files
  • deploy the .env files to the right location
  • correct centreon_cachedir in the conf file for web installation
  • modify the rights on the /var/cache/centreon folder
  • replace missing macros in some configuration files in the centreon's /bin folder

2- Update documentation

Fixes # (MON-4674 | https://github.com/centreon/centreon/issues/8249 , https://github.com/centreon/centreon/pull/8180 , https://github.com/centreon/centreon/issues/8252 )

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Check the issues and try to install the IHM using the sources on a Debian Buster OS

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

sc979
sc979 commented Feb 14, 2020
View reviewed changes
install.sh Show resolved Hide resolved
sc979
sc979 commented Feb 14, 2020
View reviewed changes
install.sh Outdated Show resolved Hide resolved
sc979
sc979 commented Feb 14, 2020
View reviewed changes
install.sh Outdated Show resolved Hide resolved
sc979
sc979 commented Feb 14, 2020
View reviewed changes
libinstall/CentWeb.sh Outdated Show resolved Hide resolved
sc979
sc979 commented Feb 14, 2020
View reviewed changes
libinstall/CentWeb.sh Outdated Show resolved Hide resolved
sc979
sc979 commented Feb 14, 2020
View reviewed changes
libinstall/functions Outdated Show resolved Hide resolved
@sc979 sc979 requested a review from ganoze February 14, 2020 16:19
@sc979 sc979 marked this pull request as ready for review February 17, 2020 16:29
sc979
sc979 commented Feb 18, 2020
View reviewed changes
libinstall/CentWeb.sh Outdated Show resolved Hide resolved
sc979
sc979 commented Feb 18, 2020
View reviewed changes
libinstall/CentWeb.sh Outdated Show resolved Hide resolved
sc979
sc979 commented Feb 18, 2020
View reviewed changes
libinstall/CentWeb.sh Outdated Show resolved Hide resolved
@sc979 sc979 force-pushed the MON-4674-source-installation-fix branch from 32d3173 to 530200e Compare February 18, 2020 08:59
@sc979 sc979 force-pushed the MON-4674-source-installation-fix branch from 530200e to f38d72c Compare February 18, 2020 09:01
cgagnaire
cgagnaire reviewed Feb 18, 2020
View reviewed changes
libinstall/CentWeb.sh Show resolved Hide resolved
libinstall/CentWeb.sh

flg_error=0
${CAT} "$file_php_temp" | while read file ; do
${CAT} "$file_php_temp" "$file_bin_temp" | while read file ; do
log "MACRO" "$(gettext "Change macro for") : $file"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log "MACRO" seems odd.

Copy link
Contributor Author

@sc979 sc979 Feb 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's only a param to specify in the logs what it is about.
The installation log can be found in the centreon's source folder,
eg : centreon-web-19.10.6/log/install_centreon.log
Here's how it's processed : https://github.com/centreon/centreon/blob/master/libinstall/functions#L121
Do you want this param's value to be modified with something more consistent ?
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's meant to be INFO.

libinstall/CentWeb.sh Show resolved Hide resolved
doc/en/installation/from_sources.rst Outdated Show resolved Hide resolved
@sc979 sc979 merged commit c1d1ddd into master Feb 19, 2020
@sc979 sc979 deleted the MON-4674-source-installation-fix branch February 19, 2020 16:10
sc979 added a commit that referenced this pull request Feb 21, 2020
@sc979
fix(core): source installation script fixes (#8341)
5253f39 
* fix(core): replace missing php macros
* enh(core): update licenses
* fix(core): change rights on centreon cache folder
* fix(core): add centreon cache folder to conf generation step
* manage .env.local.php file transfer
* generate a random key
* enh(doc): update doc and add specific DB steps
@cgagnaire cgagnaire mentioned this pull request Jul 24, 2020
Closed
@cgagnaire cgagnaire mentioned this pull request Feb 23, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgagnaire cgagnaire cgagnaire approved these changes

@kduret kduret kduret approved these changes

@lgcosta lgcosta lgcosta approved these changes

@ganoze ganoze Awaiting requested review from ganoze

@lpinsivy lpinsivy Awaiting requested review from lpinsivy

@adr-mo adr-mo Awaiting requested review from adr-mo

Assignees
No one assigned
Labels
area/install kind/documentation kind/enhancement kind/fix pr/internal-rd PR made by the Centreon R&D Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sc979 @lgcosta @kduret @cgagnaire